chrome/browser/extensions/api/top_sites/top_sites_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/top_sites/top_sites_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/terminal/terminal_private_api.cc ('k') | chrome/browser/extensions/api/top_sites/top_sites_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/top_sites/top_sites_api.cc

diff --git a/chrome/browser/extensions/api/top_sites/top_sites_api.cc b/chrome/browser/extensions/api/top_sites/top_sites_api.cc

index c229cbb8f7f1e3302a4740b31cc13a49ea3d2234..0917592988dcb92b1e76171ed61f422eeb30660c 100644

--- a/chrome/browser/extensions/api/top_sites/top_sites_api.cc

+++ b/chrome/browser/extensions/api/top_sites/top_sites_api.cc

@@ -34,7 +34,7 @@ bool TopSitesGetFunction::RunAsync() {

void TopSitesGetFunction::OnMostVisitedURLsAvailable(

const history::MostVisitedURLList& data) {

- scoped_ptr<base::ListValue> pages_value(new base::ListValue);

+ std::unique_ptr<base::ListValue> pages_value(new base::ListValue);

for (size_t i = 0; i < data.size(); i++) {

const history::MostVisitedURL& url = data[i];

if (!url.url.is_empty()) {