Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
TBR=nick@chromium.org,sky@chromium.org

Committed: https://crrev.com/24002d093cd0d2b540b0b1895d0044d44a30450d
Cr-Commit-Position: refs/heads/master@{#385943}

[dcheng, 2016-04-07 19:54:55]

Description was changed from

==========
Convert //chrome/browser/android from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
==========

[dcheng, 2016-04-07 19:54:57]

dcheng@chromium.org changed reviewers:
+ oshima@chromium.org

[dcheng, 2016-04-07 19:55:07]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[oshima, 2016-04-07 20:35:31]

rs lgtm

is there any precaution/caveat in switching to unique_ptr?

[dcheng, 2016-04-07 20:40:26]

On 2016/04/07 at 20:35:31, oshima wrote:
> rs lgtm
> 
> is there any precaution/caveat in switching to unique_ptr?

Not a lot.
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/roY78iTblYc
covers it (though there's a typo in the email, <utility> should be <memory>).

[dcheng, 2016-04-07 21:18:50]

dcheng@chromium.org changed reviewers:
+ nick@chromium.org, sky@chromium.org

[dcheng, 2016-04-07 21:18:50]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 21:18:54]

TBR sky for //chrome/browser/ui IWYU fix
TBR nick for //content IWYU fix

https://codereview.chromium.org/1870793002/diff/10001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/network_dropdown.h (right):

https://codereview.chromium.org/1870793002/diff/10001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/network_dropdown.h:8: #include <memory>
Usually I just add scoped_ptr.h, but this collides with another patch I have out
for //chrome/browser/ui. So I think this is the more expedient approach.

https://codereview.chromium.org/1870793002/diff/10001/content/public/browser/...
File content/public/browser/geolocation_provider.h (right):

https://codereview.chromium.org/1870793002/diff/10001/content/public/browser/...
content/public/browser/geolocation_provider.h:9: #include
"base/memory/scoped_ptr.h"
Meh.

[dcheng, 2016-04-07 21:18:56]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1870793002/#ps10001
(title: "iwyu fixes")

[commit-bot: I haz the power, 2016-04-07 21:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870793002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870793002/10001

[commit-bot: I haz the power, 2016-04-07 21:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:42:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-04-07 22:04:36]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 22:04:38]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1870793002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-07 22:05:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870793002/20001

[commit-bot: I haz the power, 2016-04-07 22:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:30:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-04-07 22:31:35]

Description was changed from

==========
Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
TBR=nick@chromium.org,sky@chromium.org
==========

[dcheng, 2016-04-07 22:31:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:32:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870793002/20001

[commit-bot: I haz the power, 2016-04-08 00:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 00:07:04]

Failed to apply patch for
chrome/browser/chromeos/extensions/wallpaper_private_api.cc:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/chromeos/extensions/wallpaper_private_api.cc:20
  Falling back to three-way merge...
  Applied patch to 'chrome/browser/chromeos/extensions/wallpaper_private_api.cc'
with conflicts.
  U chrome/browser/chromeos/extensions/wallpaper_private_api.cc

Patch:       chrome/browser/chromeos/extensions/wallpaper_private_api.cc
Index: chrome/browser/chromeos/extensions/wallpaper_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
index
ce46325cca76567ed8a12e5ba37f4b071c58ab96..dd2eda00e1749f0060605b3f0f108bb4ebb50bad
100644
--- a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
+++ b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/chromeos/extensions/wallpaper_private_api.h"
 
 #include <map>
+#include <memory>
 #include <set>
 #include <string>
 #include <utility>
@@ -20,7 +21,6 @@
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted_memory.h"
-#include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ -495,7 +495,7 @@ void WallpaperPrivateSetWallpaperFunction::SaveToFile() {
   std::string file_name = GURL(params->url).ExtractFileName();
   if (SaveData(chrome::DIR_CHROMEOS_WALLPAPERS, file_name, params->wallpaper))
{
     wallpaper_.EnsureRepsForSupportedScales();
-    scoped_ptr<gfx::ImageSkia> deep_copy(wallpaper_.DeepCopy());
+    std::unique_ptr<gfx::ImageSkia> deep_copy(wallpaper_.DeepCopy());
     // ImageSkia is not RefCountedThreadSafe. Use a deep copied ImageSkia if
     // post to another thread.
     BrowserThread::PostTask(
@@ -527,7 +527,7 @@ void WallpaperPrivateSetWallpaperFunction::SaveToFile() {
 }
 
 void WallpaperPrivateSetWallpaperFunction::SetDecodedWallpaper(
-    scoped_ptr<gfx::ImageSkia> image) {
+    std::unique_ptr<gfx::ImageSkia> image) {
   chromeos::WallpaperManager* wallpaper_manager =
       chromeos::WallpaperManager::Get();
 
@@ -645,7 +645,7 @@ void
WallpaperPrivateSetCustomWallpaperFunction::OnWallpaperDecoded(
 
   if (params->generate_thumbnail) {
     image.EnsureRepsForSupportedScales();
-    scoped_ptr<gfx::ImageSkia> deep_copy(image.DeepCopy());
+    std::unique_ptr<gfx::ImageSkia> deep_copy(image.DeepCopy());
     // Generates thumbnail before call api function callback. We can then
     // request thumbnail in the javascript callback.
     task_runner->PostTask(FROM_HERE,
@@ -658,7 +658,8 @@ void
WallpaperPrivateSetCustomWallpaperFunction::OnWallpaperDecoded(
 }
 
 void WallpaperPrivateSetCustomWallpaperFunction::GenerateThumbnail(
-    const base::FilePath& thumbnail_path, scoped_ptr<gfx::ImageSkia> image) {
+    const base::FilePath& thumbnail_path,
+    std::unique_ptr<gfx::ImageSkia> image) {
   DCHECK(BrowserThread::GetBlockingPool()->IsRunningSequenceOnCurrentThread(
       sequence_token_));
   if (!base::PathExists(thumbnail_path.DirName()))
@@ -691,7 +692,7 @@ WallpaperPrivateSetCustomWallpaperLayoutFunction::
     ~WallpaperPrivateSetCustomWallpaperLayoutFunction() {}
 
 bool WallpaperPrivateSetCustomWallpaperLayoutFunction::RunAsync() {
-  scoped_ptr<set_custom_wallpaper_layout::Params> params(
+  std::unique_ptr<set_custom_wallpaper_layout::Params> params(
       set_custom_wallpaper_layout::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
@@ -754,7 +755,7 @@
WallpaperPrivateGetThumbnailFunction::~WallpaperPrivateGetThumbnailFunction() {
 }
 
 bool WallpaperPrivateGetThumbnailFunction::RunAsync() {
-  scoped_ptr<get_thumbnail::Params> params(
+  std::unique_ptr<get_thumbnail::Params> params(
       get_thumbnail::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
@@ -840,7 +841,7 @@ WallpaperPrivateSaveThumbnailFunction::
     ~WallpaperPrivateSaveThumbnailFunction() {}
 
 bool WallpaperPrivateSaveThumbnailFunction::RunAsync() {
-  scoped_ptr<save_thumbnail::Params> params(
+  std::unique_ptr<save_thumbnail::Params> params(
       save_thumbnail::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);

[dcheng, 2016-04-08 00:26:48]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-08 00:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1870793002/#ps30001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-08 00:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870793002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870793002/30001

[commit-bot: I haz the power, 2016-04-08 02:42:56]

Committed patchset #4 (id:30001)

[commit-bot: I haz the power, 2016-04-08 02:44:26]

Description was changed from

==========
Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
TBR=nick@chromium.org,sky@chromium.org
==========

to

==========
Convert //chrome/browser/chromeos from scoped_ptr to std::unique_ptr

BUG=554298
TBR=nick@chromium.org,sky@chromium.org

Committed: https://crrev.com/24002d093cd0d2b540b0b1895d0044d44a30450d
Cr-Commit-Position: refs/heads/master@{#385943}
==========

[commit-bot: I haz the power, 2016-04-08 02:44:29]

Patchset 4 (id:??) landed as
https://crrev.com/24002d093cd0d2b540b0b1895d0044d44a30450d
Cr-Commit-Position: refs/heads/master@{#385943}