chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_widget_private/app_installer.cc ('k') | chrome/browser/extensions/app_data_migrator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

index e9d4408d196b52bc9f54c40f1ddf087763e84588..cb530c54dacc09172b2c2c4aaaeb7b4741e3388b 100644

--- a/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc

@@ -4,7 +4,8 @@

#include "chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.h"

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "base/values.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/file_manager/app_id.h"

@@ -70,8 +71,9 @@ WebstoreWidgetPrivateInstallWebstoreItemFunction::

ExtensionFunction::ResponseAction

WebstoreWidgetPrivateInstallWebstoreItemFunction::Run() {

- const scoped_ptr<webstore_widget_private::InstallWebstoreItem::Params> params(

- webstore_widget_private::InstallWebstoreItem::Params::Create(*args_));

+ const std::unique_ptr<webstore_widget_private::InstallWebstoreItem::Params>

+ params(

+ webstore_widget_private::InstallWebstoreItem::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params);

if (params->item_id.empty())