chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc ('k') | chrome/browser/extensions/api/tabs/app_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

index 8e1e13456eb354f76d9fc3af0d1ad62739fd1602..0cf76f8e9ed150cbc4d164aeba26f747e149503b 100644

--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc

@@ -324,13 +324,13 @@ void TabCaptureRegistry::DispatchStatusChangeEvent(

if (!router)

return;

- scoped_ptr<base::ListValue> args(new base::ListValue());

+ std::unique_ptr<base::ListValue> args(new base::ListValue());

tab_capture::CaptureInfo info;

request->GetCaptureInfo(&info);

args->Append(info.ToValue().release());

- scoped_ptr<Event> event(new Event(events::TAB_CAPTURE_ON_STATUS_CHANGED,

- tab_capture::OnStatusChanged::kEventName,

- std::move(args)));

+ std::unique_ptr<Event> event(

+ new Event(events::TAB_CAPTURE_ON_STATUS_CHANGED,

+ tab_capture::OnStatusChanged::kEventName, std::move(args)));

event->restrict_to_browser_context = browser_context_;

router->DispatchEventToExtension(request->extension_id(), std::move(event));