chrome/browser/extensions/api/bookmarks/bookmarks_api.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.h

diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.h b/chrome/browser/extensions/api/bookmarks/bookmarks_api.h

index ea12948dbf7be21020a8442003cba14a66efebc1..a04fc0b303f56b3a92d89242d0adc7a6f06904bf 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.h

+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.h

@@ -84,7 +84,7 @@ class BookmarkEventRouter : public bookmarks::BookmarkModelObserver {

// Helper to actually dispatch an event to extension listeners.

void DispatchEvent(events::HistogramValue histogram_value,

const std::string& event_name,

- scoped_ptr<base::ListValue> event_args);

+ std::unique_ptr<base::ListValue> event_args);

content::BrowserContext* browser_context_;

bookmarks::BookmarkModel* model_;

@@ -120,7 +120,7 @@ class BookmarksAPI : public BrowserContextKeyedAPI,

static const bool kServiceIsNULLWhileTesting = true;

// Created lazily upon OnListenerAdded.

- scoped_ptr<BookmarkEventRouter> bookmark_event_router_;

+ std::unique_ptr<BookmarkEventRouter> bookmark_event_router_;

};

class BookmarksFunction : public ChromeAsyncExtensionFunction,