chrome/browser/extensions/api/debugger/debugger_apitest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_apitest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/declarative/declarative_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/debugger/debugger_apitest.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_apitest.cc b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

index 91885ec717dfbcf4c3ebf02780685df87ff84cca..acf5b620351cd95208f97bacdb2ad3d30c03ed99 100644

--- a/chrome/browser/extensions/api/debugger/debugger_apitest.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_apitest.cc

@@ -96,7 +96,7 @@ testing::AssertionResult DebuggerApiTest::RunAttachFunction(

// Attach by targetId.

scoped_refptr<DebuggerGetTargetsFunction> get_targets_function =

new DebuggerGetTargetsFunction();

- scoped_ptr<base::Value> value(

+ std::unique_ptr<base::Value> value(

extension_function_test_utils::RunFunctionAndReturnSingleResult(

get_targets_function.get(), "[]", browser()));

base::ListValue* targets = nullptr;