chrome/browser/extensions/api/file_handlers/directory_util.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_handlers/directory_util.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_handlers/directory_util.h ('k') | chrome/browser/extensions/api/file_handlers/directory_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_handlers/directory_util.cc

diff --git a/chrome/browser/extensions/api/file_handlers/directory_util.cc b/chrome/browser/extensions/api/file_handlers/directory_util.cc

index 60762096a323736b25971c787b296058ff16afc7..6d08f59e6cb2f2beb8776f460fe0a053c13b2e21 100644

--- a/chrome/browser/extensions/api/file_handlers/directory_util.cc

+++ b/chrome/browser/extensions/api/file_handlers/directory_util.cc

@@ -28,7 +28,7 @@ void GetIsDirectoryFromFileInfo(const base::FilePath& path,

}

void OnGetIsDirectoryFromFileInfoCompleted(

- scoped_ptr<bool> is_directory,

+ std::unique_ptr<bool> is_directory,

const base::Callback<void(bool)>& callback) {

callback.Run(*is_directory);

}

@@ -46,7 +46,7 @@ void EntryIsDirectory(Profile* profile,

}

#endif

- scoped_ptr<bool> is_directory(new bool);

+ std::unique_ptr<bool> is_directory(new bool);

bool* const is_directory_ptr = is_directory.get();

content::BrowserThread::PostBlockingPoolTaskAndReply(