chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_handlers/mime_util.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc

diff --git a/chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc b/chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc

index bc34cc217d05e40260c2a0789f335dfcef45c655..defec7fc285c734cb8c95e6e42cbe1c5e8ddf1bb 100644

--- a/chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc

+++ b/chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc

@@ -4,12 +4,12 @@

#include "chrome/browser/extensions/api/file_handlers/mime_util.h"

+#include <memory>

#include <string>

#include <vector>

#include "base/files/file_path.h"

#include "base/files/file_util.h"

-#include "base/memory/scoped_ptr.h"

#include "base/run_loop.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/browser/browser_thread.h"

@@ -32,8 +32,9 @@ void OnMimeTypeResult(std::string* output, const std::string& mime_type) {

}

// Saves returned mime types to a vector.

-void OnMimeTypesCollected(std::vector<std::string>* output,

- scoped_ptr<std::vector<std::string> > mime_types) {

+void OnMimeTypesCollected(

+ std::vector<std::string>* output,

+ std::unique_ptr<std::vector<std::string>> mime_types) {

*output = *mime_types;

}