Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/extensions/install_tracker_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "chrome/browser/extensions/active_install_data.h" 6 #include "chrome/browser/extensions/active_install_data.h"
7 #include "chrome/browser/extensions/install_tracker.h" 7 #include "chrome/browser/extensions/install_tracker.h"
8 #include "chrome/test/base/testing_profile.h" 8 #include "chrome/test/base/testing_profile.h"
9 #include "content/public/test/test_browser_thread_bundle.h" 9 #include "content/public/test/test_browser_thread_bundle.h"
10 #include "extensions/browser/extension_registry.h" 10 #include "extensions/browser/extension_registry.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 Profile* profile() { return profile_.get(); } 58 Profile* profile() { return profile_.get(); }
59 InstallTracker* tracker() { return tracker_.get(); } 59 InstallTracker* tracker() { return tracker_.get(); }
60 60
61 void VerifyInstallData(const ActiveInstallData& original, 61 void VerifyInstallData(const ActiveInstallData& original,
62 const ActiveInstallData& retrieved) { 62 const ActiveInstallData& retrieved) {
63 EXPECT_EQ(original.extension_id, retrieved.extension_id); 63 EXPECT_EQ(original.extension_id, retrieved.extension_id);
64 EXPECT_EQ(original.percent_downloaded, retrieved.percent_downloaded); 64 EXPECT_EQ(original.percent_downloaded, retrieved.percent_downloaded);
65 } 65 }
66 66
67 content::TestBrowserThreadBundle thread_bundle_; 67 content::TestBrowserThreadBundle thread_bundle_;
68 scoped_ptr<TestingProfile> profile_; 68 std::unique_ptr<TestingProfile> profile_;
69 scoped_ptr<InstallTracker> tracker_; 69 std::unique_ptr<InstallTracker> tracker_;
70 }; 70 };
71 71
72 // Verifies that active installs are registered and deregistered correctly. 72 // Verifies that active installs are registered and deregistered correctly.
73 TEST_F(InstallTrackerTest, AddAndRemoveActiveInstalls) { 73 TEST_F(InstallTrackerTest, AddAndRemoveActiveInstalls) {
74 ActiveInstallData install_data1(kExtensionId1); 74 ActiveInstallData install_data1(kExtensionId1);
75 install_data1.percent_downloaded = 76; 75 install_data1.percent_downloaded = 76;
76 ActiveInstallData install_data2(kExtensionId2); 76 ActiveInstallData install_data2(kExtensionId2);
77 77
78 tracker_->AddActiveInstall(install_data1); 78 tracker_->AddActiveInstall(install_data1);
79 tracker_->AddActiveInstall(install_data2); 79 tracker_->AddActiveInstall(install_data2);
(...skipping 17 matching lines...) Expand all
97 EXPECT_TRUE(tracker_->GetActiveInstall(kExtensionId2)); 97 EXPECT_TRUE(tracker_->GetActiveInstall(kExtensionId2));
98 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId3)); 98 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId3));
99 } 99 }
100 100
101 // Verifies that active installs are registered and deregistered correctly 101 // Verifies that active installs are registered and deregistered correctly
102 // using ScopedActiveInstall. 102 // using ScopedActiveInstall.
103 TEST_F(InstallTrackerTest, ScopedActiveInstallDeregister) { 103 TEST_F(InstallTrackerTest, ScopedActiveInstallDeregister) {
104 // Verify the constructor that registers the install. 104 // Verify the constructor that registers the install.
105 ActiveInstallData install_data(kExtensionId1); 105 ActiveInstallData install_data(kExtensionId1);
106 install_data.percent_downloaded = 6; 106 install_data.percent_downloaded = 6;
107 scoped_ptr<ScopedActiveInstall> scoped_active_install( 107 std::unique_ptr<ScopedActiveInstall> scoped_active_install(
108 new ScopedActiveInstall(tracker(), install_data)); 108 new ScopedActiveInstall(tracker(), install_data));
109 109
110 const ActiveInstallData* retrieved_data = 110 const ActiveInstallData* retrieved_data =
111 tracker_->GetActiveInstall(kExtensionId1); 111 tracker_->GetActiveInstall(kExtensionId1);
112 ASSERT_TRUE(retrieved_data); 112 ASSERT_TRUE(retrieved_data);
113 VerifyInstallData(install_data, *retrieved_data); 113 VerifyInstallData(install_data, *retrieved_data);
114 retrieved_data = NULL; 114 retrieved_data = NULL;
115 115
116 scoped_active_install.reset(); 116 scoped_active_install.reset();
117 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1)); 117 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1));
118 118
119 // Verify the constructor that doesn't register the install. 119 // Verify the constructor that doesn't register the install.
120 scoped_active_install.reset( 120 scoped_active_install.reset(
121 new ScopedActiveInstall(tracker(), kExtensionId1)); 121 new ScopedActiveInstall(tracker(), kExtensionId1));
122 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1)); 122 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1));
123 123
124 tracker_->AddActiveInstall(install_data); 124 tracker_->AddActiveInstall(install_data);
125 EXPECT_TRUE(tracker_->GetActiveInstall(kExtensionId1)); 125 EXPECT_TRUE(tracker_->GetActiveInstall(kExtensionId1));
126 126
127 scoped_active_install.reset(); 127 scoped_active_install.reset();
128 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1)); 128 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1));
129 } 129 }
130 130
131 // Verifies that ScopedActiveInstall can be cancelled. 131 // Verifies that ScopedActiveInstall can be cancelled.
132 TEST_F(InstallTrackerTest, ScopedActiveInstallCancelled) { 132 TEST_F(InstallTrackerTest, ScopedActiveInstallCancelled) {
133 ActiveInstallData install_data(kExtensionId1); 133 ActiveInstallData install_data(kExtensionId1);
134 install_data.percent_downloaded = 87; 134 install_data.percent_downloaded = 87;
135 scoped_ptr<ScopedActiveInstall> scoped_active_install( 135 std::unique_ptr<ScopedActiveInstall> scoped_active_install(
136 new ScopedActiveInstall(tracker(), install_data)); 136 new ScopedActiveInstall(tracker(), install_data));
137 137
138 const ActiveInstallData* retrieved_data = 138 const ActiveInstallData* retrieved_data =
139 tracker_->GetActiveInstall(kExtensionId1); 139 tracker_->GetActiveInstall(kExtensionId1);
140 ASSERT_TRUE(retrieved_data); 140 ASSERT_TRUE(retrieved_data);
141 VerifyInstallData(install_data, *retrieved_data); 141 VerifyInstallData(install_data, *retrieved_data);
142 retrieved_data = NULL; 142 retrieved_data = NULL;
143 143
144 scoped_active_install->CancelDeregister(); 144 scoped_active_install->CancelDeregister();
145 scoped_active_install.reset(); 145 scoped_active_install.reset();
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 // Simulate an extension install. 201 // Simulate an extension install.
202 scoped_refptr<Extension> extension = CreateDummyExtension(kExtensionId1); 202 scoped_refptr<Extension> extension = CreateDummyExtension(kExtensionId1);
203 ASSERT_TRUE(extension.get()); 203 ASSERT_TRUE(extension.get());
204 ExtensionRegistry* registry = ExtensionRegistry::Get(profile()); 204 ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
205 ASSERT_TRUE(registry); 205 ASSERT_TRUE(registry);
206 registry->AddEnabled(extension); 206 registry->AddEnabled(extension);
207 registry->TriggerOnInstalled(extension.get(), false); 207 registry->TriggerOnInstalled(extension.get(), false);
208 208
209 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1)); 209 EXPECT_FALSE(tracker_->GetActiveInstall(kExtensionId1));
210 } 210 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/extensions/install_verifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698