chrome/browser/extensions/api/preference/chrome_direct_setting.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/platform_keys/verify_trust_api.cc ('k') | chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting.cc

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

index e2d99be1ca10544701e1b65d846d6559563783b7..87de9bb55ada2475ba7cd408d26bc65540dfb48f 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

@@ -36,7 +36,7 @@ bool GetDirectSettingFunction::RunSync() {

EXTENSION_FUNCTION_VALIDATE(preference);

const base::Value* value = preference->GetValue();

- scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);

+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);

result->Set(preference_api_constants::kValue, value->DeepCopy());

SetResult(result.release());