chrome/browser/extensions/extension_context_menu_model.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_model.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_browsertest.cc ('k') | chrome/browser/extensions/extension_context_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_model.h

diff --git a/chrome/browser/extensions/extension_context_menu_model.h b/chrome/browser/extensions/extension_context_menu_model.h

index 50acfbb1e0b21fa301dd436181d8659f16c810b6..7543dc3b86487d92e80b4e610513fc2ef6020494 100644

--- a/chrome/browser/extensions/extension_context_menu_model.h

+++ b/chrome/browser/extensions/extension_context_menu_model.h

@@ -5,10 +5,10 @@

#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTEXT_MENU_MODEL_H_

#define CHROME_BROWSER_EXTENSIONS_EXTENSION_CONTEXT_MENU_MODEL_H_

+#include <memory>

#include <string>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "ui/base/models/simple_menu_model.h"

class Browser;

@@ -133,9 +133,9 @@ class ExtensionContextMenuModel : public ui::SimpleMenuModel,

ButtonVisibility button_visibility_;

// Menu matcher for context menu items specified by the extension.

- scoped_ptr<ContextMenuMatcher> extension_items_;

+ std::unique_ptr<ContextMenuMatcher> extension_items_;

- scoped_ptr<ui::SimpleMenuModel> page_access_submenu_;

+ std::unique_ptr<ui::SimpleMenuModel> page_access_submenu_;

DISALLOW_COPY_AND_ASSIGN(ExtensionContextMenuModel);

};