Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.
All subclasses must implement the method, even if it should be empty.
This would ensure the compiler makes a developer aware of the lifecycle
concerns around RenderFrame/RenderView, and avoid the unintended
transfering ownership when inheriting the observer interface.

BUG=616214
Committed: https://crrev.com/694b50a9d759601471f5b8c8d61bd488b6a4cfba
Cr-Commit-Position: refs/heads/master@{#398395}

[xjz, 2016-06-06 17:53:50]

Patchset #1 (id:1) has been deleted

[xjz, 2016-06-06 17:55:25]

Patchset #1 (id:20001) has been deleted

[xjz, 2016-06-06 22:22:51]

Patchset #1 (id:40001) has been deleted

[xjz, 2016-06-06 22:23:12]

Patchset #1 (id:60001) has been deleted

[xjz, 2016-06-06 23:05:40]

Patchset #1 (id:80001) has been deleted

[xjz, 2016-06-06 23:07:36]

xjz@chromium.org changed reviewers:
+ avi@chromium.org, miu@chromium.org

[xjz, 2016-06-06 23:07:37]

PTAL

[xjz, 2016-06-06 23:35:51]

xjz@chromium.org changed reviewers:
+ jochen@chromium.org, torne@chromium.org

[xjz, 2016-06-06 23:35:52]

The changes are requiring all subclasses overriding OnDestruct(). No functional
change at all.

torne: PTAL changes on android_*.
jochen: PTAL changes on extensions/*.

[Avi (use Gerrit), 2016-06-07 01:47:56]

lgtm

I like it.

[Torne, 2016-06-07 11:57:49]

android_webview LGTM

[jochen (gone - plz use gerrit), 2016-06-07 17:03:56]

lgtm

[xjz, 2016-06-07 17:16:11]

xjz@chromium.org changed reviewers:
+ lcwu@chromium.org

[xjz, 2016-06-07 17:16:12]

lcwu: PTAL at chromecast/renderer/cast_media_load_deferrer.*.

[lcwu1, 2016-06-07 17:34:34]

On 2016/06/07 17:16:12, xjz wrote:
> lcwu: PTAL at chromecast/renderer/cast_media_load_deferrer.*.

chromecast/ lgtm

[miu, 2016-06-07 17:56:31]

lgtm % nits:

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
File content/public/renderer/render_frame_observer.h (right):

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
content/public/renderer/render_frame_observer.h:40: // Subclass can use this to
delete itself. If it does not, the subclass must
nit: s/Subclass/A subclass/

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
File content/public/renderer/render_view_observer.h (right):

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
content/public/renderer/render_view_observer.h:34: // Subclass can use this to
delete itself. If it does not, the subclass must
nit: s/Subclass/A subclass/

[xjz, 2016-06-07 18:06:53]

Patchset #2 (id:120001) has been deleted

[xjz, 2016-06-07 18:08:55]

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
File content/public/renderer/render_frame_observer.h (right):

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
content/public/renderer/render_frame_observer.h:40: // Subclass can use this to
delete itself. If it does not, the subclass must
On 2016/06/07 17:56:30, miu (OOO June 11-19) wrote:
> nit: s/Subclass/A subclass/

Done.

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
File content/public/renderer/render_view_observer.h (right):

https://codereview.chromium.org/2034153002/diff/100001/content/public/rendere...
content/public/renderer/render_view_observer.h:34: // Subclass can use this to
delete itself. If it does not, the subclass must
On 2016/06/07 17:56:30, miu (OOO June 11-19) wrote:
> nit: s/Subclass/A subclass/

Done.

[xjz, 2016-06-07 18:09:06]

The CQ bit was checked by xjz@chromium.org

[xjz, 2016-06-07 18:09:07]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org,
avi@chromium.org, jochen@chromium.org, miu@chromium.org, torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2034153002/#ps140001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-06-07 18:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034153002/140001

[commit-bot: I haz the power, 2016-06-07 21:49:50]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-06-07 21:52:32]

Description was changed from

==========
Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.
All subclasses must implement the method, even if it should be empty.
This would ensure the compiler makes a developer aware of the lifecycle
concerns around RenderFrame/RenderView, and avoid the unintended
transfering ownership when inheriting the observer interface.

BUG=616214
==========

to

==========
Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.
All subclasses must implement the method, even if it should be empty.
This would ensure the compiler makes a developer aware of the lifecycle
concerns around RenderFrame/RenderView, and avoid the unintended
transfering ownership when inheriting the observer interface.

BUG=616214

Committed: https://crrev.com/694b50a9d759601471f5b8c8d61bd488b6a4cfba
Cr-Commit-Position: refs/heads/master@{#398395}
==========

[commit-bot: I haz the power, 2016-06-07 21:52:35]

Patchset 2 (id:??) landed as
https://crrev.com/694b50a9d759601471f5b8c8d61bd488b6a4cfba
Cr-Commit-Position: refs/heads/master@{#398395}