content/renderer/devtools/devtools_agent.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/devtools/devtools_agent.cc

diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc

index b718f9d7b5fa77c43e5e31fb812e30b02761d273..7632e8fc3b3e3fa370fa8548879c2a6192100ac8 100644

--- a/content/renderer/devtools/devtools_agent.cc

+++ b/content/renderer/devtools/devtools_agent.cc

@@ -107,6 +107,10 @@ void DevToolsAgent::WidgetWillClose() {

ContinueProgram();

}

+void DevToolsAgent::OnDestruct() {

+ delete this;

void DevToolsAgent::sendProtocolMessage(int session_id,

int call_id,

const blink::WebString& message,

« no previous file with comments | « content/renderer/devtools/devtools_agent.h ('k') | content/renderer/devtools/devtools_client.h » ('j') | no next file with comments »