Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/page_load_metrics/renderer/metrics_render_frame_observer.h ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc
diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
index ee1cc6c0c2c8af3907c2710ef69f55c30ba2f461..0be2caded59546ea3de1ede5cef89301d9d62f46 100644
--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
@@ -149,4 +149,8 @@ bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
return no_frame;
}
+void MetricsRenderFrameObserver::OnDestruct() {
+ delete this;
+}
+
} // namespace page_load_metrics
« no previous file with comments | « components/page_load_metrics/renderer/metrics_render_frame_observer.h ('k') | components/password_manager/content/renderer/credential_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698