chrome/renderer/prerender/prerender_helper.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/prerender/prerender_helper.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/prerender/prerender_helper.h

diff --git a/chrome/renderer/prerender/prerender_helper.h b/chrome/renderer/prerender/prerender_helper.h

index caea36274025506f9b495acd822d88c6159f727f..cc10dcff8801d4ff55480fddf5b97be6d59f0710 100644

--- a/chrome/renderer/prerender/prerender_helper.h

+++ b/chrome/renderer/prerender/prerender_helper.h

@@ -26,8 +26,9 @@ class PrerenderHelper

static bool IsPrerendering(const content::RenderFrame* render_frame);

private:

- // RenderViewObserver implementation

+ // RenderFrameObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() override;

void OnSetIsPrerendering(bool is_prerendering);

« no previous file with comments | « chrome/renderer/plugins/plugin_preroller.cc ('k') | chrome/renderer/prerender/prerender_helper.cc » ('j') | no next file with comments »