content/renderer/media/media_stream_video_capturer_source.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_capturer_source.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/media_stream_video_capturer_source.h

diff --git a/content/renderer/media/media_stream_video_capturer_source.h b/content/renderer/media/media_stream_video_capturer_source.h

index a6013d0fcbbd9a233ce2ae411ca7e3202f9663cf..62301bc27e3766350cca046e853487ee0d519ba4 100644

--- a/content/renderer/media/media_stream_video_capturer_source.h

+++ b/content/renderer/media/media_stream_video_capturer_source.h

@@ -56,8 +56,7 @@ class CONTENT_EXPORT MediaStreamVideoCapturerSource

const VideoCaptureDeliverFrameCB& frame_callback) override;

void StopSourceImpl() override;

- // RenderFrame does NOT own this object. Avoid unintended multiple destruction

- // by overriding RenderFrameObserver::OnDestruct().

+ // RenderFrameObserver implementation.

void OnDestruct() final {}

// Method to bind as RunningCallback in VideoCapturerSource::StartCapture().

« no previous file with comments | « content/renderer/media/cdm/renderer_cdm_manager.cc ('k') | content/renderer/media/midi_dispatcher.h » ('j') | no next file with comments »