content/public/test/frame_load_waiter.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/frame_load_waiter.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/frame_load_waiter.h

diff --git a/content/public/test/frame_load_waiter.h b/content/public/test/frame_load_waiter.h

index d3f8ac8b33886d4e62d2b8c94e426748a50c82e7..155f92ea17f73dbe2af88e0e2fc89f8b7dfae122 100644

--- a/content/public/test/frame_load_waiter.h

+++ b/content/public/test/frame_load_waiter.h

@@ -20,7 +20,9 @@ class FrameLoadWaiter : public RenderFrameObserver {

void Wait();

private:

+ // RenderFrameObserver implementation.

void DidFinishLoad() override;

+ void OnDestruct() override;

base::RunLoop run_loop_;

« no previous file with comments | « content/public/renderer/render_view_observer.cc ('k') | content/public/test/frame_load_waiter.cc » ('j') | no next file with comments »