content/renderer/web_ui_extension_data.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/web_ui_extension_data.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/web_ui_extension_data.cc

diff --git a/content/renderer/web_ui_extension_data.cc b/content/renderer/web_ui_extension_data.cc

index 80d570fd9a13137d7e88333722f80a9399b40999..43cf15ec347f31f5ed7674808932c08cff96a2e1 100644

--- a/content/renderer/web_ui_extension_data.cc

+++ b/content/renderer/web_ui_extension_data.cc

@@ -39,4 +39,8 @@ void WebUIExtensionData::OnSetWebUIProperty(const std::string& name,

variable_map_[name] = value;

}

+void WebUIExtensionData::OnDestruct() {

+ delete this;

} // namespace content

« no previous file with comments | « content/renderer/web_ui_extension_data.h ('k') | content/shell/renderer/layout_test/blink_test_runner.h » ('j') | no next file with comments »