Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_
6 #define CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_ 6 #define CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/renderer/render_frame_observer.h" 9 #include "content/public/renderer/render_frame_observer.h"
10 10
11 namespace IPC { 11 namespace IPC {
12 class Message; 12 class Message;
13 } // namespace IPC 13 } // namespace IPC
14 14
15 namespace base { 15 namespace base {
16 class DictionaryValue; 16 class DictionaryValue;
17 } // namespace 17 } // namespace
18 18
19 namespace content { 19 namespace content {
20 struct ShellTestConfiguration; 20 struct ShellTestConfiguration;
21 class RenderFrame; 21 class RenderFrame;
22 struct ShellTestConfiguration; 22 struct ShellTestConfiguration;
23 23
24 class LayoutTestRenderFrameObserver : public RenderFrameObserver { 24 class LayoutTestRenderFrameObserver : public RenderFrameObserver {
25 public: 25 public:
26 explicit LayoutTestRenderFrameObserver(RenderFrame* render_frame); 26 explicit LayoutTestRenderFrameObserver(RenderFrame* render_frame);
27 ~LayoutTestRenderFrameObserver() override {} 27 ~LayoutTestRenderFrameObserver() override {}
28 28
29 // RenderFrameObserver implementation.
29 bool OnMessageReceived(const IPC::Message& message) override; 30 bool OnMessageReceived(const IPC::Message& message) override;
30 31
31 private: 32 private:
33 // RenderFrameObserver implementation.
34 void OnDestruct() override;
35
32 void OnLayoutDumpRequest(); 36 void OnLayoutDumpRequest();
33 void OnSetTestConfiguration(const ShellTestConfiguration& test_config); 37 void OnSetTestConfiguration(const ShellTestConfiguration& test_config);
34 void OnReplicateTestConfiguration(const ShellTestConfiguration& test_config); 38 void OnReplicateTestConfiguration(const ShellTestConfiguration& test_config);
35 void OnSetupSecondaryRenderer(); 39 void OnSetupSecondaryRenderer();
36 40
37 DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver); 41 DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);
38 }; 42 };
39 43
40 } // namespace content 44 } // namespace content
41 45
42 #endif // CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_ H_ 46 #endif // CONTENT_SHELL_RENDERER_LAYOUT_TEST_LAYOUT_TEST_RENDER_FRAME_OBSERVER_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698