chrome/renderer/banners/app_banner_client.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/banners/app_banner_client.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/banners/app_banner_client.h

diff --git a/chrome/renderer/banners/app_banner_client.h b/chrome/renderer/banners/app_banner_client.h

index b380bae3f29b5fa2dca0be7cba4e1e25c83f42c4..50ba6ad0ce8cc1df9a3c4fe67f1fe6bea24ebbef 100644

--- a/chrome/renderer/banners/app_banner_client.h

+++ b/chrome/renderer/banners/app_banner_client.h

@@ -25,9 +25,8 @@ class AppBannerClient : public content::RenderFrameObserver,

~AppBannerClient() override;

private:

- // content::RenderFrame::Observer implementation.

+ // content::RenderFrameObserver implementation.

void OnDestruct() override;

bool OnMessageReceived(const IPC::Message& message) override;

// WebAppBannerClient implementation.

« no previous file with comments | « android_webview/renderer/print_render_frame_observer.cc ('k') | chrome/renderer/banners/app_banner_client.cc » ('j') | no next file with comments »