components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/renderer/distillability_agent.cc ('k') | components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

diff --git a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

index 12ad0bc532815948f63081eeddf088af42cff84c..5a89ed9145bb4ade5b102694e15d26a58faa6831 100644

--- a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

+++ b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

@@ -42,6 +42,9 @@ class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {

void CreateDistillerPageNotifierService(

mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request);

+ // RenderFrameObserver implementation.

+ void OnDestruct() override;

// The isolated world that the distiller object should be written to.

int distiller_isolated_world_id_;