content/renderer/presentation/presentation_dispatcher.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.h ('k') | content/renderer/push_messaging/push_messaging_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/presentation/presentation_dispatcher.cc

diff --git a/content/renderer/presentation/presentation_dispatcher.cc b/content/renderer/presentation/presentation_dispatcher.cc

index bcc2eacc4c44ed1e5b6d7b492616e62c6deeeed0..f92f371d0758213accf02249e03006348e1c16a8 100644

--- a/content/renderer/presentation/presentation_dispatcher.cc

+++ b/content/renderer/presentation/presentation_dispatcher.cc

@@ -308,6 +308,10 @@ void PresentationDispatcher::DidCommitProvisionalLoad(

std::swap(message_request_queue_, empty);

}

+void PresentationDispatcher::OnDestruct() {

+ delete this;

void PresentationDispatcher::OnScreenAvailabilityUpdated(

const mojo::String& url, bool available) {

const std::string& availability_url = url.get();