content/shell/renderer/layout_test/layout_test_render_frame_observer.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/layout_test_render_frame_observer.h ('k') | content/shell/renderer/shell_render_view_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

index e86a22611c5331424ff9d05bde1b06310984fd66..4417b57ffa342cc971e3e0c685c4ecbec85b1c95 100644

--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

@@ -44,6 +44,10 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(

return handled;

}

+void LayoutTestRenderFrameObserver::OnDestruct() {

+ delete this;

void LayoutTestRenderFrameObserver::OnLayoutDumpRequest() {

std::string dump =

LayoutTestRenderThreadObserver::GetInstance()