Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSE RVER_H_ 5 #ifndef COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSE RVER_H_
6 #define COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSE RVER_H_ 6 #define COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_OBSE RVER_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "components/dom_distiller/content/common/distiller_javascript_service.m ojom.h" 9 #include "components/dom_distiller/content/common/distiller_javascript_service.m ojom.h"
10 #include "components/dom_distiller/content/renderer/distiller_native_javascript. h" 10 #include "components/dom_distiller/content/renderer/distiller_native_javascript. h"
(...skipping 24 matching lines...) Expand all
35 35
36 // Add the mojo service to a RenderFrame's service registry. 36 // Add the mojo service to a RenderFrame's service registry.
37 void RegisterMojoService(); 37 void RegisterMojoService();
38 // Flag the current page as a distiller page. 38 // Flag the current page as a distiller page.
39 void SetIsDistillerPage(); 39 void SetIsDistillerPage();
40 40
41 private: 41 private:
42 void CreateDistillerPageNotifierService( 42 void CreateDistillerPageNotifierService(
43 mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request); 43 mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request);
44 44
45 // RenderFrameObserver implementation.
46 void OnDestruct() override;
47
45 // The isolated world that the distiller object should be written to. 48 // The isolated world that the distiller object should be written to.
46 int distiller_isolated_world_id_; 49 int distiller_isolated_world_id_;
47 50
48 // Track if the current page is distilled. This is needed for testing. 51 // Track if the current page is distilled. This is needed for testing.
49 bool is_distiller_page_; 52 bool is_distiller_page_;
50 53
51 // mojo::StrongBinding<mojom::DistillerPageNotifierService> binding_; 54 // mojo::StrongBinding<mojom::DistillerPageNotifierService> binding_;
52 55
53 // Handle to "distiller" JavaScript object functionality. 56 // Handle to "distiller" JavaScript object functionality.
54 std::unique_ptr<DistillerNativeJavaScript> native_javascript_handle_; 57 std::unique_ptr<DistillerNativeJavaScript> native_javascript_handle_;
55 base::WeakPtrFactory<DistillerJsRenderFrameObserver> weak_factory_; 58 base::WeakPtrFactory<DistillerJsRenderFrameObserver> weak_factory_;
56 }; 59 };
57 60
58 } // namespace dom_distiller 61 } // namespace dom_distiller
59 62
60 #endif // COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_O BSERVER_H_ 63 #endif // COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLER_JS_RENDER_FRAME_O BSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698