components/contextual_search/renderer/overlay_js_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/page_click_tracker.cc ('k') | components/contextual_search/renderer/overlay_js_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/renderer/overlay_js_render_frame_observer.h

diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.h b/components/contextual_search/renderer/overlay_js_render_frame_observer.h

index 320c21d2fac7ee94b61fa2601eb0cfd89275ecbc..ba06f6592e30d3a08a93f9c06eed6fc6f588dc3a 100644

--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.h

+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.h

@@ -33,6 +33,9 @@ class OverlayJsRenderFrameObserver : public content::RenderFrameObserver {

void SetIsContextualSearchOverlay();

private:

+ // RenderFrameObserver implementation.

+ void OnDestruct() override;

// Add the mojo service to a RenderFrame's service registry.

void RegisterMojoService();

void CreateOverlayPageNotifierService(