Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: content/public/renderer/render_view_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/public/test/frame_load_waiter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/renderer/render_view_observer.h" 5 #include "content/public/renderer/render_view_observer.h"
6 6
7 #include "content/renderer/render_view_impl.h" 7 #include "content/renderer/render_view_impl.h"
8 8
9 namespace content { 9 namespace content {
10 10
11 RenderViewObserver::RenderViewObserver(RenderView* render_view) 11 RenderViewObserver::RenderViewObserver(RenderView* render_view)
12 : render_view_(static_cast<RenderViewImpl*>(render_view)), 12 : render_view_(static_cast<RenderViewImpl*>(render_view)),
13 routing_id_(MSG_ROUTING_NONE) { 13 routing_id_(MSG_ROUTING_NONE) {
14 // |render_view_| can be null on unit testing or if Observe() is used. 14 // |render_view_| can be null on unit testing or if Observe() is used.
15 if (render_view_) { 15 if (render_view_) {
16 routing_id_ = render_view_->GetRoutingID(); 16 routing_id_ = render_view_->GetRoutingID();
17 // TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE); 17 // TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE);
18 render_view_->AddObserver(this); 18 render_view_->AddObserver(this);
19 } 19 }
20 } 20 }
21 21
22 RenderViewObserver::~RenderViewObserver() { 22 RenderViewObserver::~RenderViewObserver() {
23 if (render_view_) 23 if (render_view_)
24 render_view_->RemoveObserver(this); 24 render_view_->RemoveObserver(this);
25 } 25 }
26 26
27 void RenderViewObserver::OnDestruct() {
28 delete this;
29 }
30
31 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) { 27 bool RenderViewObserver::OnMessageReceived(const IPC::Message& message) {
32 return false; 28 return false;
33 } 29 }
34 30
35 bool RenderViewObserver::Send(IPC::Message* message) { 31 bool RenderViewObserver::Send(IPC::Message* message) {
36 if (render_view_) 32 if (render_view_)
37 return render_view_->Send(message); 33 return render_view_->Send(message);
38 34
39 delete message; 35 delete message;
40 return false; 36 return false;
(...skipping 14 matching lines...) Expand all
55 } 51 }
56 52
57 render_view_ = static_cast<RenderViewImpl*>(render_view); 53 render_view_ = static_cast<RenderViewImpl*>(render_view);
58 if (render_view_) { 54 if (render_view_) {
59 routing_id_ = render_view_->GetRoutingID(); 55 routing_id_ = render_view_->GetRoutingID();
60 render_view_->AddObserver(this); 56 render_view_->AddObserver(this);
61 } 57 }
62 } 58 }
63 59
64 } // namespace content 60 } // namespace content
OLDNEW
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | content/public/test/frame_load_waiter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698