chrome/renderer/chrome_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff: chrome/renderer/chrome_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_	5 #ifndef CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_

6 #define CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_	6 #define CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/timer/timer.h"	9 #include "base/timer/timer.h"

10 #include "content/public/renderer/render_frame_observer.h"	10 #include "content/public/renderer/render_frame_observer.h"

(...skipping 23 matching lines...) Expand all Loading...
34 enum TextCaptureType { PRELIMINARY_CAPTURE, FINAL_CAPTURE };	34 enum TextCaptureType { PRELIMINARY_CAPTURE, FINAL_CAPTURE };

35	35

36 // RenderFrameObserver implementation.	36 // RenderFrameObserver implementation.

37 bool OnMessageReceived(const IPC::Message& message) override;	37 bool OnMessageReceived(const IPC::Message& message) override;

38 void DidFinishDocumentLoad() override;	38 void DidFinishDocumentLoad() override;

39 void DidStartProvisionalLoad() override;	39 void DidStartProvisionalLoad() override;

40 void DidFinishLoad() override;	40 void DidFinishLoad() override;

41 void DidCommitProvisionalLoad(bool is_new_navigation,	41 void DidCommitProvisionalLoad(bool is_new_navigation,

42 bool is_same_page_navigation) override;	42 bool is_same_page_navigation) override;

43 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;	43 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

	44 void OnDestruct() override;

44	45

45 // IPC handlers	46 // IPC handlers

46 void OnSetIsPrerendering(bool is_prerendering);	47 void OnSetIsPrerendering(bool is_prerendering);

47 void OnRequestReloadImageForContextNode();	48 void OnRequestReloadImageForContextNode();

48 void OnRequestThumbnailForContextNode(	49 void OnRequestThumbnailForContextNode(

49 int thumbnail_min_area_pixels,	50 int thumbnail_min_area_pixels,

50 const gfx::Size& thumbnail_max_size_pixels,	51 const gfx::Size& thumbnail_max_size_pixels,

51 int callback_id);	52 int callback_id);

52 void OnPrintNodeUnderContextMenu();	53 void OnPrintNodeUnderContextMenu();

53 void OnSetClientSidePhishingDetection(bool enable_phishing_detection);	54 void OnSetClientSidePhishingDetection(bool enable_phishing_detection);

(...skipping 11 matching lines...) Expand all Loading...
65 base::TimeDelta delay);	66 base::TimeDelta delay);

66	67

67 // Have the same lifetime as us.	68 // Have the same lifetime as us.

68 translate::TranslateHelper* translate_helper_;	69 translate::TranslateHelper* translate_helper_;

69 safe_browsing::PhishingClassifierDelegate* phishing_classifier_;	70 safe_browsing::PhishingClassifierDelegate* phishing_classifier_;

70	71

71 DISALLOW_COPY_AND_ASSIGN(ChromeRenderFrameObserver);	72 DISALLOW_COPY_AND_ASSIGN(ChromeRenderFrameObserver);

72 };	73 };

73	74

74 #endif // CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_	75 #endif // CHROME_RENDERER_CHROME_RENDER_FRAME_OBSERVER_H_

OLD	NEW