chrome/renderer/safe_browsing/phishing_classifier_delegate.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/prerender/prerenderer_client.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate.h

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate.h b/chrome/renderer/safe_browsing/phishing_classifier_delegate.h

index 6de13a2b7707882d8e79135877725e0dc054a5d1..3804a1cef10633e8b357467f13c00d1385dd6f65 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate.h

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate.h

@@ -84,6 +84,7 @@ class PhishingClassifierDelegate : public content::RenderFrameObserver {

// RenderFrameObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() override;

// Called by the RenderFrame when it receives a StartPhishingDetection IPC

// from the browser. This signals that it is ok to begin classification

« no previous file with comments | « chrome/renderer/prerender/prerenderer_client.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate.cc » ('j') | no next file with comments »