extensions/renderer/api/automation/automation_api_helper.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/automation/automation_api_helper.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/shell_render_view_observer.cc ('k') | extensions/renderer/api/automation/automation_api_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/automation/automation_api_helper.h

diff --git a/extensions/renderer/api/automation/automation_api_helper.h b/extensions/renderer/api/automation/automation_api_helper.h

index 32aa2ef0dffa562c103b1787de595a80f963dbc1..289a30045e9a1e7cbeb080d417d253d029cd7f6f 100644

--- a/extensions/renderer/api/automation/automation_api_helper.h

+++ b/extensions/renderer/api/automation/automation_api_helper.h

@@ -21,6 +21,7 @@ class AutomationApiHelper : public content::RenderViewObserver {

private:

// RenderViewObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() override;

void OnQuerySelector(int acc_obj_id,

int request_id,