Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: extensions/renderer/extensions_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/extensions_render_frame_observer.h" 5 #include "extensions/renderer/extensions_render_frame_observer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/strings/string_split.h" 9 #include "base/strings/string_split.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 base::string16 trimmed_message = message; 91 base::string16 trimmed_message = message;
92 StackTrace stack_trace = GetStackTraceFromMessage( 92 StackTrace stack_trace = GetStackTraceFromMessage(
93 &trimmed_message, 93 &trimmed_message,
94 source, 94 source,
95 stack_trace_string, 95 stack_trace_string,
96 line_number); 96 line_number);
97 Send(new ExtensionHostMsg_DetailedConsoleMessageAdded( 97 Send(new ExtensionHostMsg_DetailedConsoleMessageAdded(
98 routing_id(), trimmed_message, source, stack_trace, severity_level)); 98 routing_id(), trimmed_message, source, stack_trace, severity_level));
99 } 99 }
100 100
101 void ExtensionsRenderFrameObserver::OnDestruct() {
102 delete this;
103 }
104
101 } // namespace extensions 105 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/extensions_render_frame_observer.h ('k') | extensions/renderer/render_frame_observer_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698