Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: components/translate/content/renderer/translate_helper.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/content/renderer/translate_helper.h" 5 #include "components/translate/content/renderer/translate_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 // and may eventually become available, triggering the RESUMED event; after 631 // and may eventually become available, triggering the RESUMED event; after
632 // this, everything should start being ON_TIME. This should never run more 632 // this, everything should start being ON_TIME. This should never run more
633 // than twice in a page load, under any conditions. 633 // than twice in a page load, under any conditions.
634 // Also note that language detection is triggered off of a delay AFTER the 634 // Also note that language detection is triggered off of a delay AFTER the
635 // page load completed event has fired, making this very much off the critical 635 // page load completed event has fired, making this very much off the critical
636 // path. 636 // path.
637 content::RenderThread::Get()->UpdateHistograms( 637 content::RenderThread::Get()->UpdateHistograms(
638 content::kHistogramSynchronizerReservedSequenceNumber); 638 content::kHistogramSynchronizerReservedSequenceNumber);
639 } 639 }
640 640
641 void TranslateHelper::OnDestruct() {
642 delete this;
643 }
644
641 } // namespace translate 645 } // namespace translate
OLDNEW
« no previous file with comments | « components/translate/content/renderer/translate_helper.h ('k') | content/public/renderer/render_frame_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698