Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: content/renderer/visual_state_browsertest.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/text_input_client_observer.cc ('k') | content/renderer/web_ui_extension_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/visual_state_browsertest.cc
diff --git a/content/renderer/visual_state_browsertest.cc b/content/renderer/visual_state_browsertest.cc
index 26d9a6ddd26cb6ae254ec6db14fc406ed8db4fdc..2a8b49bff8fea2188eff5e7d8925cedc9b7cbc7a 100644
--- a/content/renderer/visual_state_browsertest.cc
+++ b/content/renderer/visual_state_browsertest.cc
@@ -50,6 +50,9 @@ class CommitObserver : public RenderViewObserver {
int GetCommitCount() { return commit_count_; }
private:
+ // RenderViewObserver implementation.
+ void OnDestruct() override { delete this; }
+
std::set<base::Closure*> quit_closures_;
int commit_count_;
};
« no previous file with comments | « content/renderer/text_input_client_observer.cc ('k') | content/renderer/web_ui_extension_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698