content/renderer/presentation/presentation_dispatcher.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/plugin_power_saver_helper.cc ('k') | content/renderer/presentation/presentation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/presentation/presentation_dispatcher.h

diff --git a/content/renderer/presentation/presentation_dispatcher.h b/content/renderer/presentation/presentation_dispatcher.h

index 2aee2c0d710a5c47106853cfaf8bf5def026ef06..e5fb81427c1bf7640cc4b2ee17927eaccd5a7c6b 100644

--- a/content/renderer/presentation/presentation_dispatcher.h

+++ b/content/renderer/presentation/presentation_dispatcher.h

@@ -94,6 +94,7 @@ class CONTENT_EXPORT PresentationDispatcher

void DidCommitProvisionalLoad(

bool is_new_navigation,

bool is_same_page_navigation) override;

+ void OnDestruct() override;

// blink::mojom::PresentationServiceClient

void OnScreenAvailabilityNotSupported(const mojo::String& url) override;

« no previous file with comments | « content/renderer/pepper/plugin_power_saver_helper.cc ('k') | content/renderer/presentation/presentation_dispatcher.cc » ('j') | no next file with comments »