components/printing/renderer/print_web_view_helper.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/printing/renderer/print_web_view_helper.h

diff --git a/components/printing/renderer/print_web_view_helper.h b/components/printing/renderer/print_web_view_helper.h

index 7232b229a656f65bdc36d86e843d12510dba58d7..fe33d5e6374be65cacd9f96029347e2c62415051 100644

--- a/components/printing/renderer/print_web_view_helper.h

+++ b/components/printing/renderer/print_web_view_helper.h

@@ -166,6 +166,7 @@ class PrintWebViewHelper

void PrintPage(blink::WebLocalFrame* frame, bool user_initiated) override;

void DidStartLoading() override;

void DidStopLoading() override;

+ void OnDestruct() override;

// Message handlers ---------------------------------------------------------

#if defined(ENABLE_BASIC_PRINTING)

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »