Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: content/renderer/media/android/renderer_media_session_manager.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/android/renderer_media_session_manager.h" 5 #include "content/renderer/media/android/renderer_media_session_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/common/media/media_session_messages_android.h" 8 #include "content/common/media/media_session_messages_android.h"
9 #include "content/public/common/media_metadata.h" 9 #include "content/public/common/media_metadata.h"
10 #include "content/public/renderer/render_thread.h" 10 #include "content/public/renderer/render_thread.h"
(...skipping 15 matching lines...) Expand all
26 bool RendererMediaSessionManager::OnMessageReceived(const IPC::Message& msg) { 26 bool RendererMediaSessionManager::OnMessageReceived(const IPC::Message& msg) {
27 bool handled = true; 27 bool handled = true;
28 IPC_BEGIN_MESSAGE_MAP(RendererMediaSessionManager, msg) 28 IPC_BEGIN_MESSAGE_MAP(RendererMediaSessionManager, msg)
29 IPC_MESSAGE_HANDLER(MediaSessionMsg_DidActivate, OnDidActivate) 29 IPC_MESSAGE_HANDLER(MediaSessionMsg_DidActivate, OnDidActivate)
30 IPC_MESSAGE_HANDLER(MediaSessionMsg_DidDeactivate, OnDidDeactivate) 30 IPC_MESSAGE_HANDLER(MediaSessionMsg_DidDeactivate, OnDidDeactivate)
31 IPC_MESSAGE_UNHANDLED(handled = false) 31 IPC_MESSAGE_UNHANDLED(handled = false)
32 IPC_END_MESSAGE_MAP() 32 IPC_END_MESSAGE_MAP()
33 return handled; 33 return handled;
34 } 34 }
35 35
36 void RendererMediaSessionManager::OnDestruct() {
37 delete this;
38 }
39
36 int RendererMediaSessionManager::RegisterMediaSession( 40 int RendererMediaSessionManager::RegisterMediaSession(
37 WebMediaSessionAndroid* session) { 41 WebMediaSessionAndroid* session) {
38 sessions_[next_session_id_] = session; 42 sessions_[next_session_id_] = session;
39 return next_session_id_++; 43 return next_session_id_++;
40 } 44 }
41 45
42 void RendererMediaSessionManager::UnregisterMediaSession(int session_id) { 46 void RendererMediaSessionManager::UnregisterMediaSession(int session_id) {
43 sessions_.erase(session_id); 47 sessions_.erase(session_id);
44 } 48 }
45 49
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 pending_activation_requests_.Remove(request_id); 92 pending_activation_requests_.Remove(request_id);
89 } 93 }
90 94
91 void RendererMediaSessionManager::OnDidDeactivate(int request_id) { 95 void RendererMediaSessionManager::OnDidDeactivate(int request_id) {
92 DCHECK(pending_deactivation_requests_.Lookup(request_id)) << request_id; 96 DCHECK(pending_deactivation_requests_.Lookup(request_id)) << request_id;
93 pending_deactivation_requests_.Lookup(request_id)->onSuccess(); 97 pending_deactivation_requests_.Lookup(request_id)->onSuccess();
94 pending_deactivation_requests_.Remove(request_id); 98 pending_deactivation_requests_.Remove(request_id);
95 } 99 }
96 100
97 } // namespace content 101 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698