Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: chrome/renderer/net/net_error_helper.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/content_settings_observer.cc ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 5 #ifndef CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 6 #define CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 void TrackClick(int tracking_id) override; 54 void TrackClick(int tracking_id) override;
55 55
56 // RenderFrameObserver implementation. 56 // RenderFrameObserver implementation.
57 void DidStartProvisionalLoad() override; 57 void DidStartProvisionalLoad() override;
58 void DidCommitProvisionalLoad(bool is_new_navigation, 58 void DidCommitProvisionalLoad(bool is_new_navigation,
59 bool is_same_page_navigation) override; 59 bool is_same_page_navigation) override;
60 void DidFinishLoad() override; 60 void DidFinishLoad() override;
61 void OnStop() override; 61 void OnStop() override;
62 void WasShown() override; 62 void WasShown() override;
63 void WasHidden() override; 63 void WasHidden() override;
64 void OnDestruct() override;
64 65
65 // IPC::Listener implementation. 66 // IPC::Listener implementation.
66 bool OnMessageReceived(const IPC::Message& message) override; 67 bool OnMessageReceived(const IPC::Message& message) override;
67 68
68 // RenderThreadObserver implementation. 69 // RenderThreadObserver implementation.
69 void NetworkStateChanged(bool online) override; 70 void NetworkStateChanged(bool online) override;
70 71
71 // Initializes |error_html| with the HTML of an error page in response to 72 // Initializes |error_html| with the HTML of an error page in response to
72 // |error|. Updates internals state with the assumption the page will be 73 // |error|. Updates internals state with the assumption the page will be
73 // loaded immediately. 74 // loaded immediately.
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // Weak factory for vending a weak pointer to a NetErrorPageController. Weak 140 // Weak factory for vending a weak pointer to a NetErrorPageController. Weak
140 // pointers are invalidated on each commit, to prevent getting messages from 141 // pointers are invalidated on each commit, to prevent getting messages from
141 // Controllers used for the previous commit that haven't yet been cleaned up. 142 // Controllers used for the previous commit that haven't yet been cleaned up.
142 base::WeakPtrFactory<NetErrorPageController::Delegate> 143 base::WeakPtrFactory<NetErrorPageController::Delegate>
143 weak_controller_delegate_factory_; 144 weak_controller_delegate_factory_;
144 145
145 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper); 146 DISALLOW_COPY_AND_ASSIGN(NetErrorHelper);
146 }; 147 };
147 148
148 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_ 149 #endif // CHROME_RENDERER_NET_NET_ERROR_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/renderer/content_settings_observer.cc ('k') | chrome/renderer/net/net_error_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698