android_webview/renderer/aw_render_view_ext.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/renderer/aw_render_view_ext.cc

diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc

index cd66797db077cd5999d7a61214489ccf1c9351af..d90c556381febd856164e9303e346887fb0d6738 100644

--- a/android_webview/renderer/aw_render_view_ext.cc

+++ b/android_webview/renderer/aw_render_view_ext.cc

@@ -29,6 +29,10 @@ void AwRenderViewExt::DidUpdateLayout() {

PostCheckContentsSize();

}

+void AwRenderViewExt::OnDestruct() {

+ delete this;

void AwRenderViewExt::PostCheckContentsSize() {

if (check_contents_size_timer_.IsRunning())

return;

« no previous file with comments | « android_webview/renderer/aw_render_view_ext.h ('k') | android_webview/renderer/print_render_frame_observer.h » ('j') | no next file with comments »