Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Side by Side Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/dom_distiller/content/renderer/distiller_js_render_frame_ob server.h" 5 #include "components/dom_distiller/content/renderer/distiller_js_render_frame_ob server.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "components/dom_distiller/content/common/distiller_page_notifier_servic e.mojom.h" 10 #include "components/dom_distiller/content/common/distiller_page_notifier_servic e.mojom.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void DistillerJsRenderFrameObserver::CreateDistillerPageNotifierService( 60 void DistillerJsRenderFrameObserver::CreateDistillerPageNotifierService(
61 mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request) { 61 mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request) {
62 // This is strongly bound to and owned by the pipe. 62 // This is strongly bound to and owned by the pipe.
63 new DistillerPageNotifierServiceImpl(this, std::move(request)); 63 new DistillerPageNotifierServiceImpl(this, std::move(request));
64 } 64 }
65 65
66 void DistillerJsRenderFrameObserver::SetIsDistillerPage() { 66 void DistillerJsRenderFrameObserver::SetIsDistillerPage() {
67 is_distiller_page_ = true; 67 is_distiller_page_ = true;
68 } 68 }
69 69
70 void DistillerJsRenderFrameObserver::OnDestruct() {
71 delete this;
72 }
73
70 } // namespace dom_distiller 74 } // namespace dom_distiller
OLDNEW
« no previous file with comments | « components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h ('k') | components/nacl/renderer/nacl_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698