components/dom_distiller/content/renderer/distillability_agent.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/content/renderer/distillability_agent.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/dom_distiller/content/renderer/distillability_agent.h ('k') | components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/metrics/histogram.h"	5 #include "base/metrics/histogram.h"

6 #include "base/strings/string_util.h"	6 #include "base/strings/string_util.h"

7	7

8 #include "components/dom_distiller/content/common/distillability_service.mojom.h "	8 #include "components/dom_distiller/content/common/distillability_service.mojom.h "

9 #include "components/dom_distiller/content/renderer/distillability_agent.h"	9 #include "components/dom_distiller/content/renderer/distillability_agent.h"

10 #include "components/dom_distiller/core/distillable_page_detector.h"	10 #include "components/dom_distiller/core/distillable_page_detector.h"

(...skipping 166 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
177 mojom::DistillabilityServicePtr distillability_service;	177 mojom::DistillabilityServicePtr distillability_service;

178 render_frame()->GetServiceRegistry()->ConnectToRemoteService(	178 render_frame()->GetServiceRegistry()->ConnectToRemoteService(

179 mojo::GetProxy(&distillability_service));	179 mojo::GetProxy(&distillability_service));

180 DCHECK(distillability_service);	180 DCHECK(distillability_service);

181 distillability_service->NotifyIsDistillable(	181 distillability_service->NotifyIsDistillable(

182 IsDistillablePage(doc, is_last), is_last);	182 IsDistillablePage(doc, is_last), is_last);

183 }	183 }

184	184

185 DistillabilityAgent::~DistillabilityAgent() {}	185 DistillabilityAgent::~DistillabilityAgent() {}

186	186

	187 void DistillabilityAgent::OnDestruct() {

	188 delete this;

	189 }

	190

187 } // namespace dom_distiller	191 } // namespace dom_distiller

OLD	NEW