content/renderer/android/renderer_date_time_picker.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/android/renderer_date_time_picker.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/renderer/android/renderer_date_time_picker.h"	5 #include "content/renderer/android/renderer_date_time_picker.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/strings/string_util.h"	9 #include "base/strings/string_util.h"

10 #include "content/common/date_time_suggestion.h"	10 #include "content/common/date_time_suggestion.h"

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
103 chooser_completion_->didChooseValue(value);	103 chooser_completion_->didChooseValue(value);

104 static_cast<RenderViewImpl*>(render_view())->DismissDateTimeDialog();	104 static_cast<RenderViewImpl*>(render_view())->DismissDateTimeDialog();

105 }	105 }

106	106

107 void RendererDateTimePicker::OnCancel() {	107 void RendererDateTimePicker::OnCancel() {

108 if (chooser_completion_)	108 if (chooser_completion_)

109 chooser_completion_->didCancelChooser();	109 chooser_completion_->didCancelChooser();

110 static_cast<RenderViewImpl*>(render_view())->DismissDateTimeDialog();	110 static_cast<RenderViewImpl*>(render_view())->DismissDateTimeDialog();

111 }	111 }

112	112

	113 void RendererDateTimePicker::OnDestruct() {

	114 delete this;

	115 }

	116

113 } // namespace content	117 } // namespace content

OLD	NEW

« no previous file with comments | « content/renderer/android/renderer_date_time_picker.h ('k') | content/renderer/devtools/devtools_agent.h » ('j') | no next file with comments »