chrome/renderer/chrome_render_frame_observer.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_render_frame_observer.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/chrome_render_frame_observer.h

diff --git a/chrome/renderer/chrome_render_frame_observer.h b/chrome/renderer/chrome_render_frame_observer.h

index c3408e47c61bbf4a5a1199d7983a20604b3ba472..99bec3afdc2c0254481240c6131b14709f699202 100644

--- a/chrome/renderer/chrome_render_frame_observer.h

+++ b/chrome/renderer/chrome_render_frame_observer.h

@@ -41,6 +41,7 @@ class ChromeRenderFrameObserver : public content::RenderFrameObserver {

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

+ void OnDestruct() override;

// IPC handlers

void OnSetIsPrerendering(bool is_prerendering);

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »