components/plugins/renderer/webview_plugin.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client.cc ('k') | components/printing/renderer/print_web_view_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index ebe456b59f7c9273a0182349d280c743bf8b4cf3..968ed150b44deff6e63b364327ce8b52663b2cd6 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -336,10 +336,7 @@ void WebViewPlugin::didReceiveResponse(unsigned identifier,

WebFrameClient::didReceiveResponse(identifier, response);

}

-void WebViewPlugin::OnDestruct() {

- // By default RenderViewObservers are destroyed along with the RenderView.

- // WebViewPlugin has a custom destruction mechanism, so we disable this.

+void WebViewPlugin::OnDestruct() {}

void WebViewPlugin::OnZoomLevelChanged() {

if (container_) {