content/renderer/shared_worker_repository.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/shared_worker_repository.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_	5 #ifndef CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_

6 #define CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_	6 #define CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_

7	7

8 #include <set>	8 #include <set>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 19 matching lines...) Expand all Loading...
30 const blink::WebString& name,	30 const blink::WebString& name,

31 DocumentID document_id,	31 DocumentID document_id,

32 const blink::WebString& content_security_policy,	32 const blink::WebString& content_security_policy,

33 blink::WebContentSecurityPolicyType,	33 blink::WebContentSecurityPolicyType,

34 blink::WebAddressSpace,	34 blink::WebAddressSpace,

35 blink::WebSharedWorkerCreationContextType,	35 blink::WebSharedWorkerCreationContextType,

36 blink::WebWorkerCreationError* error) override;	36 blink::WebWorkerCreationError* error) override;

37 void documentDetached(DocumentID document_id) override;	37 void documentDetached(DocumentID document_id) override;

38	38

39 private:	39 private:

	40 // RenderFrameObserver implementation.

	41 void OnDestruct() override;

	42

40 std::set<DocumentID> documents_with_workers_;	43 std::set<DocumentID> documents_with_workers_;

41	44

42 DISALLOW_COPY_AND_ASSIGN(SharedWorkerRepository);	45 DISALLOW_COPY_AND_ASSIGN(SharedWorkerRepository);

43 };	46 };

44	47

45 } // namespace content	48 } // namespace content

46	49

47 #endif // CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_	50 #endif // CONTENT_RENDERER_SHARED_WORKER_REPOSITORY_H_

OLD	NEW