content/renderer/push_messaging/push_messaging_dispatcher.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/push_messaging/push_messaging_dispatcher.h

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h

index 5dcbf8bf9436cfea912341e508d2eb271af9be5c..5fb894f6b5c91ef9cd9dd0d79f967a50c9c33e00 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.h

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h

@@ -39,8 +39,9 @@ class PushMessagingDispatcher : public RenderFrameObserver,

~PushMessagingDispatcher() override;

private:

- // RenderFrame::Observer implementation.

+ // RenderFrameObserver implementation.

bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() override;

// WebPushClient implementation.

void subscribe(