android_webview/renderer/aw_content_settings_client.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_content_settings_client.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/renderer/aw_content_settings_client.h

diff --git a/android_webview/renderer/aw_content_settings_client.h b/android_webview/renderer/aw_content_settings_client.h

index 7f289601fe19a618bc30175b49f20bf3bf58f269..f45fa4b76947e494ff85b810da87dd5dcdba3654 100644

--- a/android_webview/renderer/aw_content_settings_client.h

+++ b/android_webview/renderer/aw_content_settings_client.h

@@ -20,6 +20,9 @@ class AwContentSettingsClient : public content::RenderFrameObserver,

private:

~AwContentSettingsClient() override;

+ // content::RenderFrameObserver implementation.

+ void OnDestruct() override;

// blink::WebContentSettingsClient implementation.

bool allowDisplayingInsecureContent(

bool enabled_per_settings,

« no previous file with comments | « no previous file | android_webview/renderer/aw_content_settings_client.cc » ('j') | no next file with comments »