chrome/renderer/page_load_histograms.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_histograms.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/page_load_histograms.h

diff --git a/chrome/renderer/page_load_histograms.h b/chrome/renderer/page_load_histograms.h

index 369965593f14c00d1faf3ca633ce22117f65424f..1735bb197320de9601ca98f12956d42f26d146e5 100644

--- a/chrome/renderer/page_load_histograms.h

+++ b/chrome/renderer/page_load_histograms.h

@@ -25,6 +25,7 @@ class PageLoadHistograms : public content::RenderViewObserver {

// RenderViewObserver implementation.

void FrameWillClose(blink::WebFrame* frame) override;

void ClosePage() override;

+ void OnDestruct() override;

// Dump all page load histograms appropriate for the given frame.

« no previous file with comments | « chrome/renderer/net/net_error_helper.cc ('k') | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »