components/dom_distiller/content/renderer/distillability_agent.h - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/content/renderer/distillability_agent.h

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.cc ('k') | components/dom_distiller/content/renderer/distillability_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_	5 #ifndef COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_

6 #define COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_	6 #define COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_

7	7

8 #include "content/public/renderer/render_frame_observer.h"	8 #include "content/public/renderer/render_frame_observer.h"

9	9

10 namespace dom_distiller {	10 namespace dom_distiller {

11	11

12 // DistillabilityAgent returns distillability result to DistillabilityDriver.	12 // DistillabilityAgent returns distillability result to DistillabilityDriver.

13 class DistillabilityAgent : public content::RenderFrameObserver {	13 class DistillabilityAgent : public content::RenderFrameObserver {

14 public:	14 public:

15 DistillabilityAgent(content::RenderFrame* render_frame);	15 DistillabilityAgent(content::RenderFrame* render_frame);

16 ~DistillabilityAgent() override;	16 ~DistillabilityAgent() override;

17	17

18 // content::RenderFrameObserver:	18 // content::RenderFrameObserver:

19 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;	19 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type) override;

	20 void OnDestruct() override;

20 };	21 };

21	22

22 } // namespace dom_distiller	23 } // namespace dom_distiller

23	24

24 #endif // COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_	25 #endif // COMPONENTS_DOM_DISTILLER_CONTENT_RENDERER_DISTILLABILITY_AGENT_H_

OLD	NEW