android_webview/renderer/aw_message_port_client.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/aw_message_port_client.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/renderer/aw_message_port_client.cc

diff --git a/android_webview/renderer/aw_message_port_client.cc b/android_webview/renderer/aw_message_port_client.cc

index 52e6ee72adeb4f7073b9144919ea4835396c0af9..6871f2911e02aab834cb86659762bbf3a1246e04 100644

--- a/android_webview/renderer/aw_message_port_client.cc

+++ b/android_webview/renderer/aw_message_port_client.cc

@@ -44,6 +44,10 @@ bool AwMessagePortClient::OnMessageReceived(

return handled;

}

+void AwMessagePortClient::OnDestruct() {

+ delete this;

void AwMessagePortClient::OnWebToAppMessage(

int message_port_id,

const base::string16& message,

« no previous file with comments | « android_webview/renderer/aw_message_port_client.h ('k') | android_webview/renderer/aw_render_frame_ext.h » ('j') | no next file with comments »