Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10216)

Unified Diff: chrome/renderer/banners/app_banner_client.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/banners/app_banner_client.h ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/banners/app_banner_client.cc
diff --git a/chrome/renderer/banners/app_banner_client.cc b/chrome/renderer/banners/app_banner_client.cc
index 215fa29026b0b26c401c519a7daea831ca3b8e72..deec5d66bf8512e34b00bd3f420fee4f0825458d 100644
--- a/chrome/renderer/banners/app_banner_client.cc
+++ b/chrome/renderer/banners/app_banner_client.cc
@@ -17,12 +17,7 @@ AppBannerClient::AppBannerClient(content::RenderFrame* render_frame)
AppBannerClient::~AppBannerClient() {
}
-void AppBannerClient::OnDestruct() {
- // The RenderFrameImpl destructor calls RenderFrameObserver::OnDestruct, which
- // deletes this object. However, RenderFrameImpl also holds a scoped pointer
- // to AppBannerClient. Override OnDestruct to be a no-op to stop a double call
- // to the destructor and a renderer crash.
-}
+void AppBannerClient::OnDestruct() {}
bool AppBannerClient::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
« no previous file with comments | « chrome/renderer/banners/app_banner_client.h ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698