chrome/renderer/searchbox/searchbox.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox.cc

diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc

index 558ac923a214cb5f9ed764d8aca6bf78d4313edb..ae07c78cc626133819398c6fa4b7d83f13276449 100644

--- a/chrome/renderer/searchbox/searchbox.cc

+++ b/chrome/renderer/searchbox/searchbox.cc

@@ -537,3 +537,7 @@ void SearchBox::Reset() {

is_key_capture_enabled_ = false;

theme_info_ = ThemeBackgroundInfo();

}

+void SearchBox::OnDestruct() {

+ delete this;

« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/spellchecker/spellcheck_provider.h » ('j') | no next file with comments »